Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NR-158676 SingleStoreDB - AI quickstart #2045

Merged
merged 7 commits into from
Sep 20, 2023
Merged

NR-158676 SingleStoreDB - AI quickstart #2045

merged 7 commits into from
Sep 20, 2023

Conversation

pkosanam
Copy link
Contributor

@pkosanam pkosanam commented Sep 7, 2023

Ticket: https://issues.newrelic.com/browse/NR-158676

Summary

A concise description of the changes being introduced. Please review the pre-merge checklist section to validate this pull request is ready for review and merge. If it is not ready, please mark the pull request as a draft.

The owners of this repo are not experts in the subject matter of the quickstarts. We review for the quickstart to be functional and for security risks. If you are seeking feedback on the content of the quickstart, please seek out a subject matter expert. If you are not an internal NR contributor, we can do our best to connect you with a content reviewer.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

@pkosanam pkosanam added Tara Submitted by a team member from Tara team (Previously CXPUI team) in HYD aimlops AI & MLOps labels Sep 11, 2023
rahulbasu-nr
rahulbasu-nr approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@rahulbasu-nr rahulbasu-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

rahulbasu-nr
rahulbasu-nr approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@rahulbasu-nr rahulbasu-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..

@seemantk seemantk self-requested a review September 20, 2023 10:02
@pkosanam pkosanam merged commit 6ffa131 into newrelic:main Sep 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulbasu-nr rahulbasu-nr rahulbasu-nr approved these changes

@seemantk seemantk seemantk approved these changes

Assignees
No one assigned
Labels
aimlops AI & MLOps awaiting CAB approval new-quickstart Tara Submitted by a team member from Tara team (Previously CXPUI team) in HYD
Projects
NR1 Quickstarts Community
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkosanam @seemantk @rahulbasu-nr